Discussion:
Zend_Mail_Part bug fix: ZF-1847
Willie Alberty
2007-08-14 05:34:21 UTC
Permalink
When someone with commit rights to Zend_Mail has a moment, can you
please review and commit the fix contained in this issue:

http://framework.zend.com/issues/browse/ZF-1847

Thanks!

--

Willie Alberty, Owner
Spenlen Media
willie-***@public.gmane.org

http://www.spenlen.com/
Thomas Weidner
2007-08-14 05:49:53 UTC
Permalink
Why have you then self-assigned this issue to yourself when you are not
fixing it ????

You should only assign the issues you are also able to fix (this relates
also on the commit-rights to a component!!!)
Maybe that's why no one has fixed this issue ;-)

Greetings
Thomas
I18N Team Leader

----- Original Message -----
From: "Willie Alberty" <willie-***@public.gmane.org>
To: <fw-formats-***@public.gmane.org>
Sent: Tuesday, August 14, 2007 7:34 AM
Subject: [fw-formats] Zend_Mail_Part bug fix: ZF-1847
When someone with commit rights to Zend_Mail has a moment, can you please
http://framework.zend.com/issues/browse/ZF-1847
Thanks!
--
Willie Alberty, Owner
Spenlen Media
http://www.spenlen.com/
Willie Alberty
2007-08-14 06:02:02 UTC
Permalink
Post by Thomas Weidner
Why have you then self-assigned this issue to yourself when you are
not fixing it ????
You should only assign the issues you are also able to fix (this
relates also on the commit-rights to a component!!!)
Maybe that's why no one has fixed this issue ;-)
I did fix the issue. I discovered the problem while working on
production code this evening. I checked the issue tracker for an
existing bug report and found none. I then fixed the bug, updated and
re-ran the unit tests, applied the patch to my production code and
verified it there, then finally created the bug report, complete with
patch, in the issue tracker.

Since the ZF JIRA instance is not configured to automatically assign
newly created issues to the component owner, who else am I supposed
to assign it to? That is why I posted my message to this list.

Do you mean to suggest that only community members with commit rights
to a particular component are eligible to fix bugs within that
component?

--

Willie Alberty, Owner
Spenlen Media
willie-***@public.gmane.org

http://www.spenlen.com/
Thomas Weidner
2007-08-14 07:50:44 UTC
Permalink
You can add an comment to an issue if you can fix it...

Or if you assign it to yourself... you will have to reassign this issue to
"unassigned" if you are not able to commit the fix.
Otherwise... how should the development team know that you are not able to
fix it.

Also to mention... you set the issue to "fixed" which means that there is a
unit test for this case, some documentation added and it's reviewed by
another guy and of course its already committed.

So I think best would be to reopen it, and set it to unassigned...
Anyone who is able to commit it and solve the other tasks will finish your
work if you are not able to do this.

As mentioned several times before...
It's not only coding some lines... also all other tasks have to be performed
to finish an issue or to add new code to the framework.
We have to fit several needs and one is to fullfill standards, conventions
and backwards compatibility (and much more).

This is why we expect that only this guys have issues assigned who are able
to finish all tasks (including commit);-)

PS: You could ask for commit rights if you want to work on a specific
component... we would appreciate this if willie is willing. ;-)))

Greetings
Thomas
I18N Team Leader

----- Original Message -----
From: "Willie Alberty" <willie-***@public.gmane.org>
To: <fw-formats-***@public.gmane.org>
Sent: Tuesday, August 14, 2007 8:02 AM
Subject: Re: [fw-formats] Zend_Mail_Part bug fix: ZF-1847
Why have you then self-assigned this issue to yourself when you are not
fixing it ????
You should only assign the issues you are also able to fix (this relates
also on the commit-rights to a component!!!)
Maybe that's why no one has fixed this issue ;-)
I did fix the issue. I discovered the problem while working on production
code this evening. I checked the issue tracker for an existing bug report
and found none. I then fixed the bug, updated and re-ran the unit tests,
applied the patch to my production code and verified it there, then
finally created the bug report, complete with patch, in the issue
tracker.
Since the ZF JIRA instance is not configured to automatically assign
newly created issues to the component owner, who else am I supposed to
assign it to? That is why I posted my message to this list.
Do you mean to suggest that only community members with commit rights to
a particular component are eligible to fix bugs within that component?
--
Willie Alberty, Owner
Spenlen Media
http://www.spenlen.com/
Willie Alberty
2007-08-14 15:38:25 UTC
Permalink
Post by Thomas Weidner
So I think best would be to reopen it, and set it to unassigned...
Anyone who is able to commit it and solve the other tasks will
finish your work if you are not able to do this.
As mentioned several times before...
It's not only coding some lines... also all other tasks have to be
performed to finish an issue or to add new code to the framework.
We have to fit several needs and one is to fullfill standards,
conventions and backwards compatibility (and much more).
Of the requirements you mention, there are only two that I was unable
to fulfill myself:

- Code review by another community member, hence my solicitation to
the list last night.
- Commit to the repository, hence my solicitation to the list last
night.

Beyond that, the code is written. Unit tests are written. Backwards
compatibility has been verified. Documentation has been updated.
Everything necessary is included in the patch contained within the
JIRA issue.
Post by Thomas Weidner
This is why we expect that only this guys have issues assigned who
are able to finish all tasks (including commit);-)
Per your direction, I have reopened the issue and assigned it to
nobody. Hopefully it does not suffer a prolonged period of inattention.
Post by Thomas Weidner
PS: You could ask for commit rights if you want to work on a
specific component... we would appreciate this if willie is
willing. ;-)))
That is a good idea.

As I'm relying heavily on Zend_Mail for two of my current projects, I
expect that I will encounter other bugs which I will need to fix, and
may come to depend on unimplemented functionality which I shall
implement.

To the Zend_Mail component owner: I would like to request commit
privileges for Zend_Mail and Zend_Mime.

--

Willie Alberty, Owner
Spenlen Media
willie-***@public.gmane.org

http://www.spenlen.com/
Nico Edtinger
2007-08-15 12:58:29 UTC
Permalink
I'll look at ZF-1846 and ZF-1847 ASAP. I just came back from holiday,
but what I've seen both patches look ok and you should see them fixed
in SVN this week. Just give me some time to get thru my mails and stuff.

nico
Post by Willie Alberty
When someone with commit rights to Zend_Mail has a moment, can you
http://framework.zend.com/issues/browse/ZF-1847
Thanks!
--
Willie Alberty, Owner
Spenlen Media
http://www.spenlen.com/
Loading...